Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: sdk/lib/isolate/isolate.dart

Issue 1088433004: Add StackTrace.fromString constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add test. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/core/stacktrace.dart ('k') | tests/corelib/stacktrace_fromstring_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/isolate/isolate.dart
diff --git a/sdk/lib/isolate/isolate.dart b/sdk/lib/isolate/isolate.dart
index 35d2a8b15c90cb444672753f7b197714faa39ab3..b91ec267a06cc8918ef002739f1f96949818f736 100644
--- a/sdk/lib/isolate/isolate.dart
+++ b/sdk/lib/isolate/isolate.dart
@@ -372,6 +372,7 @@ class Isolate {
* created by calling `toString` on the error.
* The second element is a `String` representation of an accompanying
* stack trace, or `null` if no stack trace was provided.
+ * To convert this back to a [StackTrace] object, use [StackTrace.fromString].
*
* Listening using the same port more than once does nothing. It will only
* get each error once.
@@ -607,12 +608,6 @@ class RemoteError implements Error {
final StackTrace stackTrace;
RemoteError(String description, String stackDescription)
: _description = description,
- stackTrace = new _RemoteStackTrace(stackDescription);
+ stackTrace = new StackTrace.fromString(stackDescription);
String toString() => _description;
}
-
-class _RemoteStackTrace implements StackTrace {
- String _trace;
- _RemoteStackTrace(this._trace);
- String toString() => _trace;
-}
« no previous file with comments | « sdk/lib/core/stacktrace.dart ('k') | tests/corelib/stacktrace_fromstring_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698