Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1086083006: Properly set the exit code for failing tests run directly. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Properly set the exit code for failing tests run directly. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/013a13d3d7ae87b05086650e9be5a54a7c9e06a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/test.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M test/runner/runner_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 8 months ago (2015-04-21 22:07:08 UTC) #1
kevmoo
lgtm
5 years, 8 months ago (2015-04-21 22:11:19 UTC) #2
nweiz
5 years, 8 months ago (2015-04-21 22:11:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
013a13d3d7ae87b05086650e9be5a54a7c9e06a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698