Issue 1085423003: Revert "dart2js implementation of StringBuffer.writeAll that optimizes better."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1085423003: Revert "dart2js implementation of StringBuffer.writeAll that optimizes better." (Closed)

Created:
5 years, 8 months ago by sra1

Modified:
5 years, 8 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Revert "dart2js implementation of StringBuffer.writeAll that optimizes better." StringBuffer.writeAll is expected by pub tests to not be patched or inlined. I'll fix that and redo. TBR=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=45186

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -101 lines)			Patch
M	runtime/lib/string_buffer_patch.dart	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/core_patch.dart	View	2 chunks	+2 lines, -33 lines	0 comments	Download
M	sdk/lib/core/string_buffer.dart	View	1 chunk	+19 lines, -2 lines	0 comments	Download
M	tests/corelib/string_buffer_test.dart	View	2 chunks	+0 lines, -45 lines	0 comments	Download

Total messages: 1 (0 generated)

sra1

5 years, 8 months ago (2015-04-15 22:55:14 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45186 (presubmit successful).