Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: sdk/lib/_internal/compiler/js_lib/core_patch.dart

Issue 1085423003: Revert "dart2js implementation of StringBuffer.writeAll that optimizes better." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/string_buffer_patch.dart ('k') | sdk/lib/core/string_buffer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/js_lib/core_patch.dart
diff --git a/sdk/lib/_internal/compiler/js_lib/core_patch.dart b/sdk/lib/_internal/compiler/js_lib/core_patch.dart
index cca8f160a01ff847e8ad9a73bec5d0c6764cc57c..21be5acb8c48a9e23c2cfbca07fde3b7d32bc318 100644
--- a/sdk/lib/_internal/compiler/js_lib/core_patch.dart
+++ b/sdk/lib/_internal/compiler/js_lib/core_patch.dart
@@ -409,14 +409,8 @@ class StringBuffer {
_writeString(new String.fromCharCode(charCode));
}
- @patch
- void writeAll(Iterable objects, [String separator = ""]) {
- _contents = _writeAll(_contents, objects, separator);
- }
-
- @patch
- void writeln([Object obj = ""]) {
- _writeString('$obj\n');
+ void _writeString(str) {
+ _contents = Primitives.stringConcatUnchecked(_contents, str);
}
@patch
@@ -426,31 +420,6 @@ class StringBuffer {
@patch
String toString() => Primitives.flattenString(_contents);
-
- void _writeString(str) {
- _contents = Primitives.stringConcatUnchecked(_contents, str);
- }
-
- static String _writeAll(String string, Iterable objects, String separator) {
- Iterator iterator = objects.iterator;
- if (!iterator.moveNext()) return string;
- if (separator.isEmpty) {
- do {
- string = _writeOne(string, iterator.current);
- } while (iterator.moveNext());
- } else {
- string = _writeOne(string, iterator.current);
- while (iterator.moveNext()) {
- string = _writeOne(string, separator);
- string = _writeOne(string, iterator.current);
- }
- }
- return string;
- }
-
- static String _writeOne(String string, Object obj) {
- return Primitives.stringConcatUnchecked(string, '$obj');
- }
}
@patch
« no previous file with comments | « runtime/lib/string_buffer_patch.dart ('k') | sdk/lib/core/string_buffer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698