Issue 1083793002: Ensure multi channels aren't double-closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1083793002: Ensure multi channels aren't double-closed. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Ensure multi channels aren't double-closed. This could cause an ugly stack trace if a channel was closed at the wrong time. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/45f5d25dafa32fd2e2bc4c377601d161174b6983

Patch Set 2 : Code review changes #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	lib/src/util/multi_channel.dart	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm https://codereview.chromium.org/1083793002/diff/1/lib/src/util/multi_channel.dart File lib/src/util/multi_channel.dart (right): https://codereview.chromium.org/1083793002/diff/1/lib/src/util/multi_channel.dart#newcode97 lib/src/util/multi_channel.dart:97: var _closed = false; type this as bool

5 years, 8 months ago (2015-04-13 21:37:27 UTC) #2

nweiz

https://codereview.chromium.org/1083793002/diff/1/lib/src/util/multi_channel.dart File lib/src/util/multi_channel.dart (right): https://codereview.chromium.org/1083793002/diff/1/lib/src/util/multi_channel.dart#newcode97 lib/src/util/multi_channel.dart:97: var _closed = false; On 2015/04/13 21:37:27, kevmoo wrote: ...

5 years, 8 months ago (2015-04-13 22:30:13 UTC) #4

nweiz

5 years, 8 months ago (2015-04-13 22:30:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
45f5d25dafa32fd2e2bc4c377601d161174b6983 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1083793002: Ensure multi channels aren't double-closed. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages