Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: lib/src/util/multi_channel.dart

Issue 1083793002: Ensure multi channels aren't double-closed. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/util/multi_channel.dart
diff --git a/lib/src/util/multi_channel.dart b/lib/src/util/multi_channel.dart
index f897de9994160afadc57822a3102aed302c3fce2..34358488a80ae9de5b0bcfd64ab067e9e45cb521 100644
--- a/lib/src/util/multi_channel.dart
+++ b/lib/src/util/multi_channel.dart
@@ -93,6 +93,9 @@ class _MultiChannel extends StreamChannelMixin implements MultiChannel {
/// The subscription to [_innerStream].
StreamSubscription _innerStreamSubscription;
+ /// Whether this channel has been closed.
+ bool _closed = false;
+
Stream get stream => _streamController.stream;
final _streamController = new StreamController(sync: true);
@@ -198,6 +201,9 @@ class _MultiChannel extends StreamChannelMixin implements MultiChannel {
/// Closes the virtual channel for which incoming messages have [inputId] and
/// outgoing messages have [outputId].
void _closeChannel(int inputId, int outputId) {
+ if (_closed) return;
+ _closed = true;
+
// A message without data indicates that the virtual channel has been
// closed.
_streamControllers.remove(inputId).close();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698