Fix additional cases where analysis server might send null, violating protocol.

Fix additional cases where analysis server might send null, violating protocol.

In addition, modify the code generation so that these protocol
violations will be caught by assertions during unit tests.
Previously, they would only be caught at runtime by client code.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45211

[Paul Berry, 2015-04-16 14:51:53]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2015-04-16 14:58:04]

LGTM

[scheglov, 2015-04-16 15:01:11]

LGTM

https://codereview.chromium.org/1083223003/diff/1/pkg/analysis_server/test/ed...
File pkg/analysis_server/test/edit/refactoring_test.dart (right):

https://codereview.chromium.org/1083223003/diff/1/pkg/analysis_server/test/ed...
pkg/analysis_server/test/edit/refactoring_test.dart:997: MoveFileOptions
options;
Sort?

[Paul Berry, 2015-04-16 15:41:50]

Committed patchset #1 (id:1) manually as 45211 (presubmit successful).

[Paul Berry, 2015-04-16 15:42:21]

https://codereview.chromium.org/1083223003/diff/1/pkg/analysis_server/test/ed...
File pkg/analysis_server/test/edit/refactoring_test.dart (right):

https://codereview.chromium.org/1083223003/diff/1/pkg/analysis_server/test/ed...
pkg/analysis_server/test/edit/refactoring_test.dart:997: MoveFileOptions
options;
On 2015/04/16 15:01:10, scheglov wrote:
> Sort?

Done.