Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1077823003: Some cleanups in the code that posts results to service clients. (Closed)

Created:
5 years, 8 months ago by turnidge
Modified:
5 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Some cleanups in the code that posts results to service clients. - Remove the notion of event families and masks. This wasn't really used. - Change "response" to "result" in our response map to be more json-rpc-like. - Pass events to the service isolate as Strings. - Add more type declarations around raw data (Uint8List) responses. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45034

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -166 lines) Patch
M runtime/bin/vmservice/server.dart View 3 chunks +12 lines, -13 lines 0 comments Download
M runtime/observatory/lib/service_common.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/debugger.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.h View 2 chunks +2 lines, -16 lines 0 comments Download
M runtime/vm/service.cc View 9 chunks +8 lines, -41 lines 0 comments Download
M runtime/vm/service/client.dart View 2 chunks +5 lines, -9 lines 0 comments Download
M runtime/vm/service/constants.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 4 chunks +39 lines, -57 lines 0 comments Download
M runtime/vm/service_isolate.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
TBR=cutch This is a duplicate of an earlier cl that you reviewed... I switched machines ...
5 years, 8 months ago (2015-04-09 20:42:02 UTC) #2
Cutch
lgtm
5 years, 8 months ago (2015-04-09 20:47:23 UTC) #3
turnidge
5 years, 8 months ago (2015-04-09 21:08:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45034 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698