Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: runtime/vm/service.h

Issue 1077823003: Some cleanups in the code that posts results to service clients. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/heap.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.h
diff --git a/runtime/vm/service.h b/runtime/vm/service.h
index c63f15dd354b890500f2085d585672cd2d8ac085..28e02a6a1a6e9d5a514584e1063ca3aee649e6a5 100644
--- a/runtime/vm/service.h
+++ b/runtime/vm/service.h
@@ -31,11 +31,7 @@ class Service : public AllStatic {
// Handles a message which is directed to a particular isolate.
static void HandleIsolateMessage(Isolate* isolate, const Array& message);
- static bool EventMaskHas(uint32_t mask);
- static void SetEventMask(uint32_t mask);
static bool NeedsEvents();
- static bool NeedsDebuggerEvents();
- static bool NeedsGCEvents();
static void HandleEvent(ServiceEvent* event);
static void HandleGCEvent(GCEvent* event);
@@ -56,31 +52,21 @@ class Service : public AllStatic {
private:
static void InvokeMethod(Isolate* isolate, const Array& message);
- // These must be kept in sync with service/constants.dart
- static const int kEventFamilyDebug = 0;
- static const int kEventFamilyGC = 1;
- static const uint32_t kEventFamilyDebugMask = (1 << kEventFamilyDebug);
- static const uint32_t kEventFamilyGCMask = (1 << kEventFamilyGC);
-
static void EmbedderHandleMessage(EmbedderServiceHandler* handler,
JSONStream* js);
static EmbedderServiceHandler* FindIsolateEmbedderHandler(const char* name);
static EmbedderServiceHandler* FindRootEmbedderHandler(const char* name);
- static void SendEvent(intptr_t eventFamilyId,
- intptr_t eventType,
+ static void SendEvent(intptr_t eventType,
const Object& eventMessage);
// Does not take ownership of 'data'.
- static void SendEvent(intptr_t eventId,
- const String& meta,
+ static void SendEvent(const String& meta,
const uint8_t* data,
intptr_t size);
static EmbedderServiceHandler* isolate_service_handler_head_;
static EmbedderServiceHandler* root_service_handler_head_;
-
- static uint32_t event_mask_;
};
} // namespace dart
« no previous file with comments | « runtime/vm/heap.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698