Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1076013006: Improve return type of markUnmodifiableList to JSArray instead of List. (Closed)

Created:
5 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 8 months ago
Reviewers:
Søren Gjesse, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Improve return type of markUnmodifiableList to JSArray instead of List. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45372

Patch Set 1 #

Patch Set 2 : Add note to CHANGELOG.md #

Total comments: 2

Patch Set 3 : Fix bad change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M CHANGELOG.md View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_array.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/internal/list.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-23 06:12:31 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/1076013006/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1076013006/diff/20001/CHANGELOG.md#newcode19 CHANGELOG.md:19: * Fix behavior of `HtmlEscape` in `dart:convert`. No ...
5 years, 8 months ago (2015-04-23 09:04:19 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/1076013006/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1076013006/diff/20001/CHANGELOG.md#newcode19 CHANGELOG.md:19: * Fix behavior of `HtmlEscape` in `dart:convert`. No longer ...
5 years, 8 months ago (2015-04-23 09:07:07 UTC) #4
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-23 10:21:13 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 45372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698