sdk/lib/_internal/compiler/js_lib/js_array.dart - Issue 1076013006: Improve return type of markUnmodifiableList to JSArray instead of List.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_array.dart

Issue 1076013006: Improve return type of markUnmodifiableList to JSArray instead of List. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix bad change. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/js_lib/js_array.dart

diff --git a/sdk/lib/_internal/compiler/js_lib/js_array.dart b/sdk/lib/_internal/compiler/js_lib/js_array.dart

index ef8c0e606653c6ea33d858768c17232a4bee499b..2afabdd98e9694296f1f83ac3e377ba50042a0c7 100644

--- a/sdk/lib/_internal/compiler/js_lib/js_array.dart

+++ b/sdk/lib/_internal/compiler/js_lib/js_array.dart

@@ -83,7 +83,8 @@ class JSArray<E> extends Interceptor implements List<E>, JSIndexable {

// to know if the property exists.

JS('void', r'#.fixed$length = Array', list);

JS('void', r'#.immutable$list = Array', list);

- return JS('List', '#', list);

+ // TODO(23309): Make it detectable that the list has fixed length.

+ return JS('JSArray', '#', list);

}

checkMutable(reason) {

« no previous file with comments | « CHANGELOG.md ('k') | sdk/lib/internal/list.dart » ('j') | no next file with comments »