Issue 107513004: Test infrastructure: add retry to browser controller sending "done" message.

Issue 107513004: Test infrastructure: add retry to browser controller sending "done" message. (Closed)

Created:
7 years ago by Bill Hesse

Modified:
7 years ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Test infrastructure: add retry to browser controller sending "done" message. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=30950

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
	M	tools/testing/dart/browser_controller.dart	View		5 chunks	+18 lines, -7 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

in general lgt https://codereview.chromium.org/107513004/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/107513004/diff/1/tools/testing/dart/browser_controller.dart#newcode1264 tools/testing/dart/browser_controller.dart:1264: client.open(method, path); As discussed offline, if ...

7 years ago (2013-12-06 14:42:58 UTC) #2

kustermann

On 2013/12/06 14:42:58, kustermann wrote: > in general lgt > > https://codereview.chromium.org/107513004/diff/1/tools/testing/dart/browser_controller.dart > File tools/testing/dart/browser_controller.dart ...

7 years ago (2013-12-06 14:43:06 UTC) #3

Bill Hesse

7 years ago (2013-12-06 16:38:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r30950 (presubmit successful).

Expand Messages | Collapse Messages