Test infrastructure: add retry to browser controller sending "done" message.

tools/testing/dart/browser_controller.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 library browser;
 
 import "dart:async";
 import "dart:convert" show LineSplitter, UTF8;
 import "dart:core";
 import "dart:io";
 
@@ skipping 1243 matching lines @@
         }
       }
 
       function contactBrowserController(method,
                                         path,
                                         callback,
                                         msg,
                                         isUrlEncoded) {
         var client = new XMLHttpRequest();
         client.onreadystatechange = callback;
         client.open(method, path);

[kustermann, 2013/12/06 14:42:58]

As discussed offline, if there is a client.onerror callback, set it.

         if (isUrlEncoded) {
           client.setRequestHeader('Content-type',
                                   'application/x-www-form-urlencoded');
         }
         client.send(msg);
       }
 
       function getNextTask() {
         // Until we have the next task we set the current_id to a specific
         // negative value.
         contactBrowserController(
-            'GET', '$nextTestPath/$browserId', newTaskHandler, "", false); 
+            'GET', '$nextTestPath/$browserId', newTaskHandler, "", false);
       }
 
       function run(url) {
         number_of_tests++;
         number_div.innerHTML = number_of_tests;
         executing_div.innerHTML = url;
         if (use_iframe) {
           embedded_iframe.src = url;
         } else {
           if (testing_window == undefined) {
@@ skipping 14 matching lines @@
 
       function reportError(msg) {
         function handleReady() {
           if (this.readyState == this.DONE && this.status != 200) {
             var error = 'Sending back error did not succeeed: ' + this.status;
             error = error + '. Failed to send msg: ' + msg;
             error_div.innerHTML = error;
           }
         }
         contactBrowserController(
-            'POST', '$errorReportingUrl?test=1', handleReady, msg, true); 
+            'POST', '$errorReportingUrl?test=1', handleReady, msg, true);
       }
 
       function reportMessage(msg, isFirstMessage, isStatusUpdate) {
         if (isFirstMessage) {
           test_completed = false;
           current_id = next_id;
           contactBrowserController(
             'POST', '$startedPath/${browserId}?id=' + current_id,
             function () {}, msg, true);
         } else if (isStatusUpdate) {
             contactBrowserController(
               'POST', '$statusUpdatePath/${browserId}?id=' + current_id,
               function() {}, msg, true);
         } else {
           var is_double_report = test_completed;
+          var retry = 0;
           test_completed = true;
 
+          function reportDoneMessage() {
+            contactBrowserController(
+                'POST', '$reportPath/${browserId}?id=' + current_id,
+                handleReady, msg, true);
+          }
+
           function handleReady() {
             if (this.readyState == this.DONE) {
               if (this.status == 200) {
                 if (!is_double_report) {
                   getNextTask();
                 }
               } else {
-                reportError('Error sending result to server');
+                reportError('Error sending result to server. Status: ' +
+                            this.status + ' Retry: ' + retry);

[kustermann, 2013/12/06 14:42:58]

Could you test if this 'reportError()' functionality is working?

+                retry++;
+                if (retry < 3) {
+                  setTimeout(reportDoneMessage, 1000);
+                }
               }
             }
           }
-          contactBrowserController(
-            'POST', '$reportPath/${browserId}?id=' + current_id, handleReady,
-            msg, true);
+
+          reportDoneMessage();
         }
       }
 
       function parseResult(result) {
         var parsedData = null;
         try {
           parsedData = JSON.parse(result);
         } catch(error) { }
         return parsedData;
       }
 
       function messageHandler(e) {
         var msg = e.data;
         if (typeof msg != 'string') return;
-        
+
         var parsedData = parseResult(msg);
         if (parsedData) {
           // Only if the JSON was valid, we'll post it back.
           var message = parsedData['message'];
           var isFirstMessage = parsedData['is_first_message'];
           var isStatusUpdate = parsedData['is_status_update'];
           var isDone = parsedData['is_done'];
           if (!isFirstMessage && !isStatusUpdate) {
             if (!isDone) {
               alert("Bug in test_controller.js: " +
@@ skipping 20 matching lines @@
     Dart test driver, number of tests: <div id="number"></div><br>
     Currently executing: <div id="currently_executing"></div><br>
     Unhandled error: <div id="unhandled_error"></div>
     <iframe id="embedded_iframe"></iframe>
   </body>
 </html>
 """;
     return driverContent;
   }
 }