Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1073983010: Add asserts that isolates have a root library set up before they become runnable. (Closed)

Created:
5 years, 8 months ago by rmacnak
Modified:
5 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add asserts that isolates have a root library set up before they become runnable. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M runtime/lib/mirrors.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/spawn_function_root_library_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 8 months ago (2015-04-16 01:02:18 UTC) #2
Ivan Posva
LGTM -ip
5 years, 8 months ago (2015-04-17 00:15:02 UTC) #3
rmacnak
5 years, 8 months ago (2015-04-17 00:44:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45224 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698