runtime/vm/dart_api_impl.cc - Issue 1073983010: Add asserts that isolates have a root library set up before they become runnable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1073983010: Add asserts that isolates have a root library set up before they become runnable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index 89d602af857135d890e2efc000a61e066ff23182..3316c215145c885cc06705ce2700cd8e79a8712b 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -1501,6 +1501,10 @@ DART_EXPORT bool Dart_IsolateMakeRunnable(Dart_Isolate isolate) {

}

// TODO(16615): Validate isolate parameter.

Isolate* iso = reinterpret_cast<Isolate*>(isolate);

+ if (iso->object_store()->root_library() == Library::null()) {

+ // The embedder should have called Dart_LoadScript by now.

+ return false;

+ }

return iso->MakeRunnable();

}

« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »