Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Issue 1072623002: refactor optype to better filter invocation/prefixed suggestions (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

refactor optype to better filter invocation/prefixed suggestions BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45001

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -73 lines) Patch
M pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart View 1 chunk +13 lines, -11 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart View 1 chunk +18 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/optype.dart View 10 chunks +42 lines, -15 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 13 chunks +39 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-04-08 20:39:55 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-04-09 00:02:04 UTC) #3
danrubel
5 years, 8 months ago (2015-04-09 12:16:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45001 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698