refactor optype to better filter invocation/prefixed suggestions

pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.contributor.dart.local;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart' as protocol
     show Element, ElementKind;
@@ skipping 69 matching lines @@
  * A contributor for calculating `completion.getSuggestions` request results
  * for the local library in which the completion is requested.
  */
 class LocalReferenceContributor extends DartCompletionContributor {
   @override
   bool computeFast(DartCompletionRequest request) {
     OpType optype = request.optype;
 
     // Collect suggestions from the specific child [AstNode] that contains
     // the completion offset and all of its parents recursively.
-    if (optype.includeReturnValueSuggestions ||
-        optype.includeTypeNameSuggestions ||
-        optype.includeVoidReturnSuggestions) {
-      _LocalVisitor localVisitor =
-          new _LocalVisitor(request, request.offset, optype);
-      localVisitor.visit(request.target.containingNode);
-    }
-    if (optype.includeStatementLabelSuggestions ||
-        optype.includeCaseLabelSuggestions) {
-      _LabelVisitor labelVisitor = new _LabelVisitor(request,
-          optype.includeStatementLabelSuggestions,
-          optype.includeCaseLabelSuggestions);
-      labelVisitor.visit(request.target.containingNode);
-    }
-    if (optype.includeConstructorSuggestions) {
-      new _ConstructorVisitor(request).visit(request.target.containingNode);
+    if (!optype.isPrefixed) {
+      if (optype.includeReturnValueSuggestions ||
+          optype.includeTypeNameSuggestions ||
+          optype.includeVoidReturnSuggestions) {
+        _LocalVisitor localVisitor =
+            new _LocalVisitor(request, request.offset, optype);
+        localVisitor.visit(request.target.containingNode);
+      }
+      if (optype.includeStatementLabelSuggestions ||
+          optype.includeCaseLabelSuggestions) {
+        _LabelVisitor labelVisitor = new _LabelVisitor(request,
+            optype.includeStatementLabelSuggestions,
+            optype.includeCaseLabelSuggestions);
+        labelVisitor.visit(request.target.containingNode);
+      }
+      if (optype.includeConstructorSuggestions) {
+        new _ConstructorVisitor(request).visit(request.target.containingNode);
+      }
     }
 
     // If target is an argument in an argument list
     // then suggestions may need to be adjusted
     return request.target.argIndex == null;
   }
 
   @override
   Future<bool> computeFull(DartCompletionRequest request) {
     _updateSuggestions(request);
@@ skipping 575 matching lines @@
   bool _isVoid(TypeName returnType) {
     if (returnType != null) {
       Identifier id = returnType.name;
       if (id != null && id.name == 'void') {
         return true;
       }
     }
     return false;
   }
 }