- Remove JSCRE from the runtime.

- Remove JSCRE from the runtime.

R=vegorov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44987

[Ivan Posva, 2015-04-08 21:07:28]

iposva@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2015-04-08 21:10:54]

LGTM!

[Vyacheslav Egorov (Google), 2015-04-08 21:14:07]

some comments

https://codereview.chromium.org/1071713003/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/1071713003/diff/1/runtime/vm/object.h#newcode...
runtime/vm/object.h:7503: ASSERT(sizeof(RawJSRegExp) ==
OFFSET_OF_RETURNED_VALUE(RawJSRegExp, data));
dead assertion, in raw_object.h also dead member

  uint8_t* data() { OPEN_ARRAY_START(uint8_t, uint8_t); }

https://codereview.chromium.org/1071713003/diff/1/runtime/vm/object.h#newcode...
runtime/vm/object.h:7507: static intptr_t InstanceSize(intptr_t len) {
Dead code.

https://codereview.chromium.org/1071713003/diff/1/runtime/vm/object.h#newcode...
runtime/vm/object.h:7513: static RawJSRegExp* New(intptr_t length, Heap::Space
space = Heap::kNew);
Length is a dead variable (always 0 now).

[Ivan Posva, 2015-04-08 23:31:46]

Thanks!

-Ivan

https://codereview.chromium.org/1071713003/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/1071713003/diff/1/runtime/vm/object.h#newcode...
runtime/vm/object.h:7503: ASSERT(sizeof(RawJSRegExp) ==
OFFSET_OF_RETURNED_VALUE(RawJSRegExp, data));
On 2015/04/08 21:14:07, Vyacheslav Egorov (Google) wrote:
> dead assertion, in raw_object.h also dead member
> 
>   uint8_t* data() { OPEN_ARRAY_START(uint8_t, uint8_t); }

Done.

https://codereview.chromium.org/1071713003/diff/1/runtime/vm/object.h#newcode...
runtime/vm/object.h:7507: static intptr_t InstanceSize(intptr_t len) {
On 2015/04/08 21:14:07, Vyacheslav Egorov (Google) wrote:
> Dead code.

Done.

https://codereview.chromium.org/1071713003/diff/1/runtime/vm/object.h#newcode...
runtime/vm/object.h:7513: static RawJSRegExp* New(intptr_t length, Heap::Space
space = Heap::kNew);
On 2015/04/08 21:14:07, Vyacheslav Egorov (Google) wrote:
> Length is a dead variable (always 0 now).

Adjusted the remaining pieces in the VM dealing with variable length RawJSRegExp
objects.

[Vyacheslav Egorov (Google), 2015-04-08 23:52:32]

still lgtm

https://codereview.chromium.org/1071713003/diff/40001/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1071713003/diff/40001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:2770: // TODO(18854): Need to implement a way
of recreating the irrexp functions.
I think they can just be written out - lazy compile stub should take care of
compiling them correctly. Though I am not sure.

[Ivan Posva, 2015-04-08 23:58:49]

Still Thanks!

-Ivan

https://codereview.chromium.org/1071713003/diff/40001/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1071713003/diff/40001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:2770: // TODO(18854): Need to implement a way
of recreating the irrexp functions.
On 2015/04/08 23:52:32, Vyacheslav Egorov (Google) wrote:
> I think they can just be written out - lazy compile stub should take care of
> compiling them correctly. Though I am not sure.

Discussing with Siva we would prefer not to send the functions across and
instead recreate them if you do indeed send are regexp object between isolates.

Not this CL though. This has been not functioning for a very long time (aka
forever).

[Ivan Posva, 2015-04-08 23:59:43]

Committed patchset #3 (id:40001) manually as r44987 (presubmit successful).