- Remove JSCRE from the runtime.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 7482 matching lines @@
   void* GetDataStartAddress() const;
   static RawJSRegExp* FromDataStartAddress(void* data);
   const char* Flags() const;
 
   virtual bool CanonicalizeEquals(const Instance& other) const;
 
   static const intptr_t kBytesPerElement = 1;
   static const intptr_t kMaxElements = kSmiMax / kBytesPerElement;
 
   static intptr_t InstanceSize() {
     ASSERT(sizeof(RawJSRegExp) == OFFSET_OF_RETURNED_VALUE(RawJSRegExp, data));

[Vyacheslav Egorov (Google), 2015/04/08 21:14:07]

dead assertion, in raw_object.h also dead member

  uint8_t* data() { OPEN_ARRAY_START(uint8_t, uint8_t); }

[Ivan Posva, 2015/04/08 23:31:45]

Done.

-    if (FLAG_use_jscre) {
-      return 0;
-    }
     return RoundedAllocationSize(sizeof(RawJSRegExp));
   }
 
   static intptr_t InstanceSize(intptr_t len) {

[Vyacheslav Egorov (Google), 2015/04/08 21:14:07]

Dead code.

[Ivan Posva, 2015/04/08 23:31:45]

Done.

     ASSERT(0 <= len && len <= kMaxElements);
     return RoundedAllocationSize(
         sizeof(RawJSRegExp) + (len * kBytesPerElement));
   }
 
   static RawJSRegExp* New(intptr_t length, Heap::Space space = Heap::kNew);

[Vyacheslav Egorov (Google), 2015/04/08 21:14:07]

Length is a dead variable (always 0 now).

[Ivan Posva, 2015/04/08 23:31:45]

Adjusted the remaining pieces in the VM dealing with variable length RawJSRegExp
objects.

 
  private:
   void set_type(RegExType type) const {
     StoreNonPointer(&raw_ptr()->type_flags_,
                     TypeBits::update(type, raw_ptr()->type_flags_));
   }
   void set_flags(intptr_t value) const {
     StoreNonPointer(&raw_ptr()->type_flags_,
                     FlagsBits::update(value, raw_ptr()->type_flags_));
   }
@@ skipping 267 matching lines @@
 
 
 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
                                                intptr_t index) {
   return array.At((index * kEntryLength) + kTargetFunctionIndex);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_