Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1070563007: Remove dead ClassMirror._methods. Remove FunctionTypeMirror.members|constructors that should have b… (Closed)

Created:
5 years, 8 months ago by rmacnak
Modified:
5 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove dead ClassMirror._methods. Remove FunctionTypeMirror.members|constructors that should have been removed along with ClassMirror.members|constructors. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=44986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M runtime/lib/mirrors_impl.dart View 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 8 months ago (2015-04-08 21:51:51 UTC) #2
regis
LGTM
5 years, 8 months ago (2015-04-08 21:59:48 UTC) #3
rmacnak
5 years, 8 months ago (2015-04-08 22:17:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44986 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698