Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3018)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 1070563007: Remove dead ClassMirror._methods. Remove FunctionTypeMirror.members|constructors that should have b… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index 125cbc1718ffc918f7572184d4e69a6f704ff325..e3f87bac601879b3c0b7766bb715ad79eb80289b 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -15,16 +15,6 @@ class _InternalMirrorError {
String toString() => _msg;
}
-Map _filterMap(Map<Symbol, dynamic> old_map, bool filter(Symbol key, value)) {
- Map new_map = new Map<Symbol, dynamic>();
- old_map.forEach((key, value) {
- if (filter(key, value)) {
- new_map[key] = value;
- }
- });
- return new UnmodifiableMapView(new_map);
-}
-
Map _makeMemberMap(List mirrors) {
return new UnmodifiableMapView<Symbol, DeclarationMirror>(
new Map<Symbol, DeclarationMirror>.fromIterable(
@@ -785,16 +775,6 @@ class _LocalClassMirror extends _LocalObjectMirror
return _cachedMembers;
}
- Map<Symbol, MethodMirror> _cachedMethods;
- Map<Symbol, MethodMirror> get _methods {
- if (_cachedMethods == null) {
- _cachedMethods = _filterMap(
- _members,
- (key, value) => (value is MethodMirror && value.isRegularMethod));
- }
- return _cachedMethods;
- }
-
Map<Symbol, MethodMirror> _cachedConstructors;
Map<Symbol, MethodMirror> get _constructors {
if (_cachedConstructors == null) {
@@ -1017,8 +997,6 @@ class _LocalFunctionTypeMirror extends _LocalClassMirror
get typeVariables => emptyList;
get typeArguments => emptyList;
get metadata => emptyList;
- Map<Symbol, Mirror> get members => emptyMap;
- Map<Symbol, MethodMirror> get constructors => emptyMap;
String toString() => "FunctionTypeMirror on '${_n(simpleName)}'";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698