Make the construction of a ProcessResult public

Make the construction of a ProcessResult public

There was really no need for it to be a private implementation.

BUG=http://dartbug.com/23070
R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44935

[Lasse Reichstein Nielsen, 2015-04-07 12:38:45]

lgtm

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart#new...
sdk/lib/io/process.dart:434: * process started with [:Process.run:].
[:Process.run:] -> [Process.run] or [Process.runSync].

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart#new...
sdk/lib/io/process.dart:449: * of type `String`.
Make ProcessResult generic with the type of this and stderr as parameter.

Then the user can write:

 ProcessResult<String> result = Process.run(..., encoding: UTF8);

and work happily and typed forever after.

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart#new...
sdk/lib/io/process.dart:462: * Process id from the process.
Process id of the process
?

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart#new...
sdk/lib/io/process.dart:470: * `Process.run` and `Process.runSync`. However for
some applications
Comma after "however". Maybe rewrite to something more direct.
Maybe just remove the comment. The use of a class belongs in the class
description, not the constructor. The constructor is completely transparently
named and hardly needs a comment at all.

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart#new...
sdk/lib/io/process.dart:473: const ProcessResult(int this.pid,
Remove the `const` if possible. It makes little-to-no sense that the result of
running a computation can be known at compile time.

If you use it as "const" somewhere, then just make those final and lazily
created instead.

[Søren Gjesse, 2015-04-07 13:05:35]

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart#new...
sdk/lib/io/process.dart:434: * process started with [:Process.run:].
On 2015/04/07 12:38:44, Lasse Reichstein Nielsen wrote:
> [:Process.run:] -> [Process.run] or [Process.runSync].
> 
> 

Done.

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart#new...
sdk/lib/io/process.dart:449: * of type `String`.
On 2015/04/07 12:38:45, Lasse Reichstein Nielsen wrote:
> Make ProcessResult generic with the type of this and stderr as parameter.
> 
> Then the user can write:
> 
>  ProcessResult<String> result = Process.run(..., encoding: UTF8);
> 
> and work happily and typed forever after.

One can specify different encodings for stdout and stderr, so that would require
two different type parameters:

  ProcessResult<String, List<int>> result =
      Process.run(..., stdoutEncoding: UTF8, stderrEncoding: null);

  ProcessResult<String, String> result =
      Process.run(..., stdoutEncoding: UTF8, stderrEncoding: UTF8);

which does not look that nice.

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart#new...
sdk/lib/io/process.dart:462: * Process id from the process.
On 2015/04/07 12:38:44, Lasse Reichstein Nielsen wrote:
> Process id of the process
> ?

Done.

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart#new...
sdk/lib/io/process.dart:470: * `Process.run` and `Process.runSync`. However for
some applications
On 2015/04/07 12:38:44, Lasse Reichstein Nielsen wrote:
> Comma after "however". Maybe rewrite to something more direct.
> Maybe just remove the comment. The use of a class belongs in the class
> description, not the constructor. The constructor is completely transparently
> named and hardly needs a comment at all.

I removed the comment.

https://codereview.chromium.org/1068803002/diff/1/sdk/lib/io/process.dart#new...
sdk/lib/io/process.dart:473: const ProcessResult(int this.pid,
On 2015/04/07 12:38:44, Lasse Reichstein Nielsen wrote:
> Remove the `const` if possible. It makes little-to-no sense that the result of
> running a computation can be known at compile time.
> 
> If you use it as "const" somewhere, then just make those final and lazily
> created instead.

Done.

[Søren Gjesse, 2015-04-07 13:05:56]

Committed patchset #2 (id:20001) manually as 44935 (presubmit successful).