Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1068263002: improve parser recovery for import statements (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

improve parser recovery for import statements BUG=dartbug.com/23108 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44978

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -10 lines) Patch
M pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_contributor_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +13 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-04-08 14:50:49 UTC) #2
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-08 15:44:24 UTC) #3
danrubel
5 years, 8 months ago (2015-04-08 18:26:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698