Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart

Issue 1068263002: improve parser recovery for import statements (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/keyword_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart b/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
index adc4b603084c9a4a3f9d5b6a63ec90170fbd3576..b979b8ba30bdcde748ba6680d5ee639d174d459d 100644
--- a/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
@@ -107,7 +107,8 @@ class _KeywordVisitor extends GeneralizingAstVisitor {
}
}
if (previousMember is ImportDirective) {
- if (previousMember.semicolon == null || previousMember.semicolon.isSynthetic) {
+ if (previousMember.semicolon == null ||
+ previousMember.semicolon.isSynthetic) {
// If the prior member is an unfinished import directive
// then the user is probably finishing that
_addImportDirectiveKeywords(previousMember);
@@ -143,7 +144,7 @@ class _KeywordVisitor extends GeneralizingAstVisitor {
_addSuggestion(Keyword.DEFERRED, DART_RELEVANCE_HIGH);
}
}
- if (entity == node.semicolon) {
+ if (entity == node.semicolon || node.combinators.contains(entity)) {
_addImportDirectiveKeywords(node);
}
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/keyword_contributor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698