do not suggest elements from internal sdk libs

do not suggest elements from internal sdk libs

BUG=dartbug.com/23104
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44939

[danrubel, 2015-04-06 22:39:04]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-04-07 01:40:27]

lgtm

https://codereview.chromium.org/1064743002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart
(right):

https://codereview.chromium.org/1064743002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart:283:
for (var lib in context.sourceFactory.dartSdk.sdkLibraries) {
Please replace "var" with "SdkLibrary".  I had to go look up the definition of
DartSdk.sdkLibraries in order to know the type of "lib".

https://codereview.chromium.org/1064743002/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart
(right):

https://codereview.chromium.org/1064743002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart:270:
var contributor = this.contributor as ImportedReferenceContributor;
IMHO, it's slightly clearer to say:

  ImportedReferenceContributor contributor = this.contributor;

It's also more in line with the coding standards we follow in the analyzer and
analysis server, which is to use explicit variable types.

Also, it has the benefit of being (ever so slightly) faster in unchecked mode.

[danrubel, 2015-04-07 16:52:26]

https://codereview.chromium.org/1064743002/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart
(right):

https://codereview.chromium.org/1064743002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart:270:
var contributor = this.contributor as ImportedReferenceContributor;
On 2015/04/07 01:40:27, Paul Berry wrote:
> IMHO, it's slightly clearer to say:
> 
>   ImportedReferenceContributor contributor = this.contributor;
> 
> It's also more in line with the coding standards we follow in the analyzer and
> analysis server, which is to use explicit variable types.
> 
> Also, it has the benefit of being (ever so slightly) faster in unchecked mode.

Done.

[danrubel, 2015-04-07 16:52:50]

Committed patchset #2 (id:20001) manually as 44939 (presubmit successful).