do not suggest elements from internal sdk libs

pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.dart.cache;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/protocol_server.dart'
     hide Element, ElementKind;
 import 'package:analysis_server/src/services/completion/completion_manager.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analysis_server/src/services/completion/suggestion_builder.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/resolver.dart';
 import 'package:analyzer/src/generated/source.dart';
+import 'package:analyzer/src/generated/sdk.dart';
 
 /**
  * The `DartCompletionCache` contains cached information from a prior code
  * completion operation.
  */
 class DartCompletionCache extends CompletionCache {
 
   /**
    * A hash of the import directives
    * or `null` if nothing has been cached.
@@ skipping 239 matching lines @@
       _importedCompletions.add(suggestion.completion);
     }
   }
 
   /**
    * Add suggestions for all top level elements in the context
    * excluding those elemnents for which suggestions have already been added.
    */
   void _addNonImportedElementSuggestions(
       List<SearchMatch> matches, Set<LibraryElement> excludedLibs) {
+
+    // Exclude internal Dart SDK libraries
+    for (var lib in context.sourceFactory.dartSdk.sdkLibraries) {

[Paul Berry, 2015/04/07 01:40:27]

Please replace "var" with "SdkLibrary".  I had to go look up the definition of
DartSdk.sdkLibraries in order to know the type of "lib".

+      if (lib.isInternal) {
+        Source libUri = context.sourceFactory.forUri(lib.shortName);
+        if (libUri != null) {
+          LibraryElement libElem = context.getLibraryElement(libUri);
+          if (libElem != null) {
+            excludedLibs.add(libElem);
+          }
+        }
+      }
+    }
+
     AnalysisContext sdkContext = context.sourceFactory.dartSdk.context;
     matches.forEach((SearchMatch match) {
       if (match.kind == MatchKind.DECLARATION) {
         Element element = match.element;
         if ((element.context == context || element.context == sdkContext) &&
             element.isPublic &&
             !excludedLibs.contains(element.library) &&
             !_importedCompletions.contains(element.displayName)) {
           _addSuggestion(element, DART_RELEVANCE_LOW);
         }
@@ skipping 94 matching lines @@
   @override
   void visitFunctionTypeAliasElement(FunctionTypeAliasElement element) {
     cache._addSuggestion(element, DART_RELEVANCE_DEFAULT);
   }
 
   @override
   void visitTopLevelVariableElement(TopLevelVariableElement element) {
     cache._addSuggestion(element, DART_RELEVANCE_DEFAULT);
   }
 }