Use mock ProcessResult in optimizing_pub_package_map_provider_test.

Use mock ProcessResult in optimizing_pub_package_map_provider_test.

This will make it feasible to cherry-pick this test into older
versions of Dart in which the ProcessResult constructor is private.

Also, fix some "unused variable" hints.

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45183

[Paul Berry, 2015-04-15 20:30:07]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-04-15 20:31:18]

LGTM

[Paul Berry, 2015-04-15 20:55:27]

Committed patchset #1 (id:1) manually as 45183 (presubmit successful).

[kevmoo, 2015-04-15 21:28:43]

On 2015/04/15 20:55:27, Paul Berry wrote:
> Committed patchset #1 (id:1) manually as 45183 (presubmit successful).

As of 1.10, you can access the ctor for ProcessResult directly. No mocking
needed.

It might be good to add a TODO to remove the mock once the analyzer is happy to
use >= 1.10 SDK

[kevmoo, 2015-04-15 21:29:16]

On 2015/04/15 21:28:43, kevmoo wrote:
> On 2015/04/15 20:55:27, Paul Berry wrote:
> > Committed patchset #1 (id:1) manually as 45183 (presubmit successful).
> 
> As of 1.10, you can access the ctor for ProcessResult directly. No mocking
> needed.
> 
> It might be good to add a TODO to remove the mock once the analyzer is happy
to
> use >= 1.10 SDK

I just read your note. User error.