Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: pkg/analysis_server/test/source/optimizing_pub_package_map_provider_test.dart

Issue 1062853006: Use mock ProcessResult in optimizing_pub_package_map_provider_test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/source/optimizing_pub_package_map_provider_test.dart
diff --git a/pkg/analysis_server/test/source/optimizing_pub_package_map_provider_test.dart b/pkg/analysis_server/test/source/optimizing_pub_package_map_provider_test.dart
index c604130d98ee63dec332983218ef5db3da9fb008..769b6830349d052b1dd5df8216f11f46fe8fc9ee 100644
--- a/pkg/analysis_server/test/source/optimizing_pub_package_map_provider_test.dart
+++ b/pkg/analysis_server/test/source/optimizing_pub_package_map_provider_test.dart
@@ -97,12 +97,12 @@ class OptimizingPubPackageMapProviderTest {
io.ProcessResult pubListResult;
void setPubListError() {
- pubListResult = new io.ProcessResult(0, 1, '', 'ERROR');
+ pubListResult = new _MockProcessResult(0, 1, '', 'ERROR');
}
void setPubListResult({Map<String, String> packages: const {},
List<String> input_files: const []}) {
- pubListResult = new io.ProcessResult(0, 0,
+ pubListResult = new _MockProcessResult(0, 0,
JSON.encode({'packages': packages, 'input_files': input_files}), '');
}
@@ -131,8 +131,6 @@ class OptimizingPubPackageMapProviderTest {
test_computePackageMap_noPreviousInfo_pubListError() {
String pubspecLock = posix.join(projectFolder.path, 'pubspec.lock');
- String pkgName = 'foo';
- String pkgPath = '/pkg/foo';
setPubListError();
OptimizingPubPackageMapInfo info =
provider.computePackageMap(projectFolder);
@@ -229,3 +227,19 @@ class OptimizingPubPackageMapProviderTest {
return pubListResult;
}
}
+
+class _MockProcessResult implements io.ProcessResult {
+ @override
+ final int pid;
+
+ @override
+ final int exitCode;
+
+ @override
+ final stdout;
+
+ @override
+ final stderr;
+
+ _MockProcessResult(this.pid, this.exitCode, this.stdout, this.stderr);
+}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698