Issue 1062643002: Add an additional closed check to BrowserServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1062643002: Add an additional closed check to BrowserServer. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add an additional closed check to BrowserServer. The [url] getter becomes invalid once the server has been shut down, so we should avoid it. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/bbe86e6aa7e7e12e0def66bb295751b80de0f0fa

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	lib/src/runner/browser/server.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

nweiz

On 2015/04/04 00:52:11, kevmoo wrote: > LGTM, but ... What does this fix? A flaky ...

5 years, 8 months ago (2015-04-06 19:39:25 UTC) #3

nweiz

5 years, 8 months ago (2015-04-06 19:39:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bbe86e6aa7e7e12e0def66bb295751b80de0f0fa (presubmit successful).