Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: lib/src/runner/browser/server.dart

Issue 1062643002: Add an additional closed check to BrowserServer. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/server.dart
diff --git a/lib/src/runner/browser/server.dart b/lib/src/runner/browser/server.dart
index e96fc57648bef0db10494aa42e62a4817c132408..b5f5f3f1b8bfa102d6cbf36a195b208cd85682d6 100644
--- a/lib/src/runner/browser/server.dart
+++ b/lib/src/runner/browser/server.dart
@@ -165,6 +165,8 @@ class BrowserServer {
.then((_) => _pubServeUrl.resolve('$suitePrefix.html'));
} else {
return _compileSuite(path).then((dir) {
+ if (_closed) return null;
+
// Add a trailing slash because at least on Chrome, the iframe's
// window.location.href will do so automatically, and if that differs
// from the original URL communication will fail.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698