Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1061043002: Remove union type support from analyzer. (Closed)

Created:
5 years, 8 months ago by Paul Berry
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove union type support from analyzer. This feature was never enabled, never left the experimental stage, and is getting in the way of other work (e.g. fixing bugs 21912 and 22976). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -864 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 7 chunks +3 lines, -271 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 7 chunks +1 line, -145 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +1 line, -78 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 2 chunks +0 lines, -198 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 8 chunks +0 lines, -138 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 8 months ago (2015-04-06 20:30:45 UTC) #2
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-06 21:14:52 UTC) #3
Paul Berry
5 years, 8 months ago (2015-04-06 22:41:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44930 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698