Remove union type support from analyzer.

pkg/analyzer/test/generated/resolver_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.resolver_test;
 
 import 'dart:collection';
 
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
@@ skipping 2191 matching lines @@
 m() {
   var i = '';
   n(i);
 }
 n(int i) {}''');
     resolve(source);
     assertErrors(source, [HintCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
     verify([source]);
   }
 
-  void test_argumentTypeNotAssignable_unionTypeMethodMerge() {
-    enableUnionTypes(false);
-    Source source = addSource(r'''
-class A {
-  int m(int x) => 0;
-}
-class B {
-  String m(String x) => '0';
-}
-f(A a, B b) {
-  var ab;
-  if (0 < 1) {
-    ab = a;
-  } else {
-    ab = b;
-  }
-  ab.m(0.5);
-}''');
-    resolve(source);
-    assertErrors(source, [HintCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
-    verify([source]);
-  }
-
   void test_deadCode_deadBlock_conditionalElse() {
     Source source = addSource(r'''
 f() {
   true ? 1 : 2;
 }''');
     resolve(source);
     assertErrors(source, [HintCode.DEAD_CODE]);
     verify([source]);
   }
 
@@ skipping 408 matching lines @@
 class A {
   @deprecated
   m() {}
   n() {m();}
 }''');
     resolve(source);
     assertErrors(source, [HintCode.DEPRECATED_MEMBER_USE]);
     verify([source]);
   }
 
-  void test_deprecatedAnnotationUse_deprecatedMethodCalledOnUnionType() {
-    enableUnionTypes(false);
-    Source source = addSource(r'''
-class A {
-  @deprecated f() => 0;
-}
-class B extends A {}
-main(A a, B b) {
-  var x;
-  if (0 < 1) {
-    x = a;
-  } else {
-    x = b;
-  }
-  x.f(); // Here [x] has type [{A,B}] but we still want the deprecation warning.
-}''');
-    resolve(source);
-    assertErrors(source, [HintCode.DEPRECATED_MEMBER_USE]);
-    verify([source]);
-  }
-
   void test_deprecatedAnnotationUse_export() {
     Source source = addSource("export 'deprecated_library.dart';");
     addNamedSource("/deprecated_library.dart", r'''
 @deprecated
 library deprecated_library;
 class A {}''');
     resolve(source);
     assertErrors(source, [HintCode.DEPRECATED_MEMBER_USE]);
     verify([source]);
   }
@@ skipping 438 matching lines @@
   f(var a, var a2) {
     a = new A();
     a2 = new A();
     a += a2;
   }
 }''');
     resolve(source);
     assertErrors(source, [HintCode.UNDEFINED_METHOD]);
   }
 
-  void test_undefinedMethod_unionType_noSuchMethod() {
-    enableUnionTypes(false);
-    Source source = addSource(r'''
-class A {
-  int m(int x) => 0;
-}
-class B {
-  String m() => '0';
-}
-f(A a, B b) {
-  var ab;
-  if (0 < 1) {
-    ab = a;
-  } else {
-    ab = b;
-  }
-  ab.n();
-}''');
-    resolve(source);
-    assertErrors(source, [HintCode.UNDEFINED_METHOD]);
-  }
-
   void test_undefinedOperator_binaryExpression() {
     Source source = addSource(r'''
 class A {}
 f(var a) {
   if(a is A) {
     a + 1;
   }
 }''');
     resolve(source);
     assertErrors(source, [HintCode.UNDEFINED_OPERATOR]);
@@ skipping 3368 matching lines @@
   if (message is Function) {
     message = dynamic_;
   }
   int s = message;
 }''');
     resolve(source);
     assertNoErrors(source);
     verify([source]);
   }
 
-  void test_issue20904BuggyTypePromotionAtIfJoin_2() {
-    // https://code.google.com/p/dart/issues/detail?id=20904
-    enableUnionTypes(false);
-    Source source = addSource(r'''
-f(var message) {
-  if (message is Function) {
-    message = '';
-  }
-  int s = message;
-}''');
-    resolve(source);
-    assertNoErrors(source);
-    verify([source]);
-  }
-
   void test_issue20904BuggyTypePromotionAtIfJoin_3() {
     // https://code.google.com/p/dart/issues/detail?id=20904
     Source source = addSource(r'''
 f(var message) {
   var dynamic_;
   if (message is Function) {
     message = dynamic_;
   } else {
     return;
   }
@@ skipping 1164 matching lines @@
     CompilationUnitElementImpl compilationUnit =
         new CompilationUnitElementImpl(fileName);
     compilationUnit.source = _createNamedSource(fileName);
     LibraryElementImpl library = new LibraryElementImpl.forNode(
         context, AstFactory.libraryIdentifier2([libraryName]));
     library.definingCompilationUnit = compilationUnit;
     library.parts = sourcedCompilationUnits;
     return library;
   }
 
-  /**
-   * Enable optionally strict union types for the current test.
-   *
-   * @param strictUnionTypes `true` if union types should be strict.
-   */
-  void enableUnionTypes(bool strictUnionTypes) {
-    AnalysisEngine.instance.enableUnionTypes = true;
-    AnalysisEngine.instance.strictUnionTypes = strictUnionTypes;
-  }
-
   Expression findTopLevelConstantExpression(
           CompilationUnit compilationUnit, String name) =>
       findTopLevelDeclaration(compilationUnit, name).initializer;
 
   VariableDeclaration findTopLevelDeclaration(
       CompilationUnit compilationUnit, String name) {
     for (CompilationUnitMember member in compilationUnit.declarations) {
       if (member is TopLevelVariableDeclaration) {
         for (VariableDeclaration variable in member.variables.variables) {
           if (variable.name.name == name) {
             return variable;
           }
         }
       }
     }
     return null;
     // Not found
   }
 
   /**
    * In the rare cases we want to group several tests into single "test_" method, so need a way to
    * reset test instance to reuse it.
    */
   void reset() {
     analysisContext2 = AnalysisContextFactory.contextWithCore();
-    // These defaults are duplicated for the editor in
-    // editor/tools/plugins/com.google.dart.tools.core/.options .
-    AnalysisEngine.instance.enableUnionTypes = false;
-    AnalysisEngine.instance.strictUnionTypes = false;
   }
 
   /**
    * Reset the analysis context to have the given options applied.
    *
    * @param options the analysis options to be applied to the context
    */
   void resetWithOptions(AnalysisOptions options) {
     analysisContext2 =
         AnalysisContextFactory.contextWithCoreAndOptions(options);
@@ skipping 4828 matching lines @@
     ClassDeclaration classA = unit.declarations[0] as ClassDeclaration;
     InterfaceType typeA = classA.element.type;
     FunctionDeclaration function = unit.declarations[1] as FunctionDeclaration;
     BlockFunctionBody body =
         function.functionExpression.body as BlockFunctionBody;
     ReturnStatement statement = body.block.statements[1] as ReturnStatement;
     SimpleIdentifier variableName = statement.expression as SimpleIdentifier;
     expect(variableName.propagatedType, same(typeA));
   }
 
-  void test_issue20904BuggyTypePromotionAtIfJoin_2() {
-    // https://code.google.com/p/dart/issues/detail?id=20904
-    enableUnionTypes(false);
-    String code = r'''
-f(var message) {
-  if (message is Function) {
-    message = '';
-  }
-  message; // marker
-}''';
-    DartType t = _findMarkedIdentifier(code, "; // marker").propagatedType;
-    expect(typeProvider.stringType == t, isFalse);
-    expect(typeProvider.functionType == t, isFalse);
-  }
-
   void test_issue20904BuggyTypePromotionAtIfJoin_5() {
     // https://code.google.com/p/dart/issues/detail?id=20904
     //
     // This is not an example of the 20904 bug, but rather,
     // an example of something that one obvious fix changes inadvertently: we
     // want to avoid using type information from is-checks when it
     // loses precision. I can't see how to get a bad hint this way, since
     // it seems the propagated type is not used to generate hints when a
     // more precise type would cause no hint. For example, for code like the
     // following, when the propagated type of [x] is [A] -- as happens for the
@@ skipping 193 matching lines @@
   if (x) {
     y = 0;
   } else {
     return y;
   }
   // Propagated type is [int] here: correct.
   return y; // marker
 }''', null, typeProvider.intType);
   }
 
-  void test_mergePropagatedTypesAtJoinPoint_6() {
-    // https://code.google.com/p/dart/issues/detail?id=19929
-    //
-    // Labeled [break]s are unsafe for the purposes of
-    // [isAbruptTerminationStatement].
-    //
-    // This is tricky: the [break] jumps back above the [if], making
-    // it into a loop of sorts. The [if] type-propagation code assumes
-    // that [break] does not introduce a loop.
-    enableUnionTypes(false);
-    String code = r'''
-f() {
-  var x = 0;
-  var c = false;
-  L: 
-  if (c) {
-  } else {
-    x = '';
-    c = true;
-    break L;
-  }
-  x; // marker
-}''';
-    DartType t = _findMarkedIdentifier(code, "; // marker").propagatedType;
-    expect(typeProvider.intType.isSubtypeOf(t), isTrue);
-    expect(typeProvider.stringType.isSubtypeOf(t), isTrue);
-  }
-
   void test_mutatedOutsideScope() {
     // https://code.google.com/p/dart/issues/detail?id=22732
     Source source = addSource(r'''
 class Base {
 }
 
 class Derived extends Base {
   get y => null;
 }
 
@@ skipping 881 matching lines @@
         // check propagated type
         FunctionType propagatedType = node.propagatedType as FunctionType;
         expect(propagatedType.returnType, test.typeProvider.stringType);
       } on AnalysisException catch (e, stackTrace) {
         thrownException[0] = new CaughtException(e, stackTrace);
       }
     }
     return null;
   }
 }