Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1058793003: A CheckClass instruction that compares against a null class only can be optimized to check instance… (Closed)

Created:
5 years, 8 months ago by srdjan
Modified:
5 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

A CheckClass instruction that compares against a null class only can be optimized to check instance instead of its class, since null-class has only one instance (not counting the sentinel, transitional etc temorary instances). R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M runtime/vm/intermediate_language.h View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +14 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 8 months ago (2015-04-02 21:08:14 UTC) #2
Cutch
lgtm
5 years, 8 months ago (2015-04-03 20:29:39 UTC) #3
srdjan
5 years, 8 months ago (2015-04-06 17:33:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44920 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698