runtime/vm/intermediate_language_mips.cc - Issue 1058793003: A CheckClass instruction that compares against a null class only can be optimized to check instance…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 1058793003: A CheckClass instruction that compares against a null class only can be optimized to check instance… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_mips.cc

===================================================================

--- runtime/vm/intermediate_language_mips.cc (revision 44874)

+++ runtime/vm/intermediate_language_mips.cc (working copy)

@@ -4670,7 +4670,12 @@

ICData::kDeoptCheckClass,

licm_hoisted_ ? ICData::kHoisted : 0);

if (IsNullCheck()) {

- __ BranchEqual(locs()->in(0).reg(), Object::null_object(), deopt);

+ if (DeoptIfNull()) {

+ __ BranchEqual(locs()->in(0).reg(), Object::null_object(), deopt);

+ } else {

+ ASSERT(DeoptIfNotNull());

+ __ BranchNotEqual(locs()->in(0).reg(), Object::null_object(), deopt);

+ }

return;

}

« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »