Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1057483004: Clean up handling of constants in the CPS backend. (Closed)

Created:
5 years, 8 months ago by Kevin Millikin (Google)
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Clean up handling of constants in the CPS backend. Before: constant-valued expressions were usually compiled by the JS constant compiler task, which surprisingly produces a Dart (not JS) constant. After: use the already computed constant value of a constant-valued expression. This is looked up in one of two ways depending on whether the expression is an identifier or not. For primitive constants (Booleans, doubles, integers, strings, and null) simply construct them as they have not had a value computed. Also, fix a variety of small bugs. In some case the fix is disabling an incorrect code path and bailing out of the compiler. BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=45335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -213 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 9 chunks +32 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 13 chunks +34 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +1 line, -5 lines 0 comments Download
M tests/co19/co19-dart2js.status View 11 chunks +9 lines, -4 lines 0 comments Download
M tests/isolate/isolate.status View 4 chunks +9 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 51 chunks +96 lines, -122 lines 0 comments Download
M tests/lib/lib.status View 10 chunks +16 lines, -16 lines 0 comments Download
M tests/standalone/standalone.status View 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Kevin Millikin (Google)
5 years, 8 months ago (2015-04-22 09:35:47 UTC) #2
Johnni Winther
lgtm
5 years, 8 months ago (2015-04-22 09:56:45 UTC) #3
Kevin Millikin (Google)
5 years, 8 months ago (2015-04-22 10:59:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45335 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698