Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: pkg/analyzer2dart/lib/src/cps_generator.dart

Issue 1057483004: Clean up handling of constants in the CPS backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer2dart/lib/src/cps_generator.dart
diff --git a/pkg/analyzer2dart/lib/src/cps_generator.dart b/pkg/analyzer2dart/lib/src/cps_generator.dart
index 8f8ff9bf782c606be7bd7dcd29a22413e448cadc..24a5eb264d31617dfc4254c5ead7c3b0b53d10a3 100644
--- a/pkg/analyzer2dart/lib/src/cps_generator.dart
+++ b/pkg/analyzer2dart/lib/src/cps_generator.dart
@@ -269,36 +269,36 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
@override
ir.Constant visitNullLiteral(NullLiteral node) {
- return irBuilder.buildNullLiteral();
+ return irBuilder.buildNullConstant();
}
@override
ir.Constant visitBooleanLiteral(BooleanLiteral node) {
- return irBuilder.buildBooleanLiteral(node.value);
+ return irBuilder.buildBooleanConstant(node.value);
}
@override
ir.Constant visitDoubleLiteral(DoubleLiteral node) {
- return irBuilder.buildDoubleLiteral(node.value);
+ return irBuilder.buildDoubleConstant(node.value);
}
@override
ir.Constant visitIntegerLiteral(IntegerLiteral node) {
- return irBuilder.buildIntegerLiteral(node.value);
+ return irBuilder.buildIntegerConstant(node.value);
}
@override
visitAdjacentStrings(AdjacentStrings node) {
String value = node.stringValue;
if (value != null) {
- return irBuilder.buildStringLiteral(value);
+ return irBuilder.buildStringConstant(value);
}
giveUp(node, "Non constant adjacent strings.");
}
@override
ir.Constant visitSimpleStringLiteral(SimpleStringLiteral node) {
- return irBuilder.buildStringLiteral(node.value);
+ return irBuilder.buildStringConstant(node.value);
}
@override
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698