fix keyword completion in class body

fix keyword completion in class body

BUG=
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44894

[danrubel, 2015-04-03 20:53:30]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-04-03 21:20:51]

lgtm

https://codereview.chromium.org/1057403003/diff/40001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/completion/keyword_computer.dart
(right):

https://codereview.chromium.org/1057403003/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/keyword_computer.dart:73: if
(entity == node.rightBracket || node.members.contains(entity)) {
Nit: since request.target.containingNode is always the parent of
request.target.entity, you don't need to search through the node to check
whether entity is one of its members.  It should be sufficient just to do:

if (entity == node.rightBracket || entity is ClassMember)

[danrubel, 2015-04-03 22:10:40]

https://codereview.chromium.org/1057403003/diff/40001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/completion/keyword_computer.dart
(right):

https://codereview.chromium.org/1057403003/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/keyword_computer.dart:73: if
(entity == node.rightBracket || node.members.contains(entity)) {
On 2015/04/03 21:20:51, Paul Berry wrote:
> Nit: since request.target.containingNode is always the parent of
> request.target.entity, you don't need to search through the node to check
> whether entity is one of its members.  It should be sufficient just to do:
> 
> if (entity == node.rightBracket || entity is ClassMember)

Good suggestion. Done.

[danrubel, 2015-04-03 22:13:02]

Committed patchset #4 (id:60001) manually as 44894 (presubmit successful).