Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1057333004: Continue improving the documentation for the vm service protocol. (Closed)

Created:
5 years, 8 months ago by turnidge
Modified:
5 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Continue improving the documentation for the vm service protocol. Clean up the protocol a bit as I go. --- Addendum: Clean up inconsistencies between field and function ownership in the protocol. Change the names of implicit closure functions (!) Committed: https://code.google.com/p/dart/source/detail?r=44923

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : ownership for functions, names #

Patch Set 4 : #

Total comments: 8

Patch Set 5 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+565 lines, -195 lines) Patch
M runtime/lib/isolate.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.html View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_ref.dart View 1 2 1 chunk +7 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.html View 1 2 2 chunks +4 lines, -20 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 9 chunks +59 lines, -55 lines 0 comments Download
M runtime/observatory/test/coverage_test.dart View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/test/eval_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 11 chunks +59 lines, -53 lines 0 comments Download
M runtime/vm/object_test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/service/service.idl View 1 2 3 4 7 chunks +418 lines, -36 lines 0 comments Download
M runtime/vm/service_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
turnidge
5 years, 8 months ago (2015-04-04 00:07:47 UTC) #2
turnidge
On 2015/04/04 00:07:47, turnidge wrote: Ok, John, made some big changes... PTAL
5 years, 8 months ago (2015-04-06 18:30:09 UTC) #3
Cutch
LGTMwC https://codereview.chromium.org/1057333004/diff/60001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1057333004/diff/60001/runtime/vm/object.cc#newcode12571 runtime/vm/object.cc:12571: // jsobj.AddProperty("alive", is_alive()); uncomment and rename to _alive ...
5 years, 8 months ago (2015-04-06 18:43:03 UTC) #4
turnidge
https://codereview.chromium.org/1057333004/diff/60001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1057333004/diff/60001/runtime/vm/object.cc#newcode12571 runtime/vm/object.cc:12571: // jsobj.AddProperty("alive", is_alive()); On 2015/04/06 18:43:03, Cutch wrote: > ...
5 years, 8 months ago (2015-04-06 19:23:58 UTC) #5
turnidge
5 years, 8 months ago (2015-04-06 19:25:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 44923 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698