Add List.unmodifiable constructor.

Add List.unmodifiable constructor.

R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45334

[Lasse Reichstein Nielsen, 2015-04-21 12:56:10]

lrn@google.com changed reviewers:
+ floitsch@google.com, iposva@chromium.org, sgjesse@google.com

[Søren Gjesse, 2015-04-22 08:40:13]

lgtm

https://codereview.chromium.org/1056353004/diff/1/sdk/lib/_internal/compiler/...
File sdk/lib/_internal/compiler/js_lib/core_patch.dart (right):

https://codereview.chromium.org/1056353004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/core_patch.dart:290: class X<T> { Type get
type => T; }
?

[Lasse Reichstein Nielsen, 2015-04-22 10:48:39]

Committed patchset #2 (id:20001) manually as 45334 (presubmit successful).

[Lasse Reichstein Nielsen, 2015-04-22 10:56:37]

https://codereview.chromium.org/1056353004/diff/1/sdk/lib/_internal/compiler/...
File sdk/lib/_internal/compiler/js_lib/core_patch.dart (right):

https://codereview.chromium.org/1056353004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/core_patch.dart:290: class X<T> { Type get
type => T; }
Whoops, debug code.

[sra1, 2015-04-22 21:17:30]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-04-22 21:17:31]

Optimization of this is poor.

https://codereview.chromium.org/1056353004/diff/20001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/js_lib/js_array.dart (right):

https://codereview.chromium.org/1056353004/diff/20001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/js_lib/js_array.dart:86: return JS('List', '#',
list);
1. Change 'List' to 'JSArray'.

Leaving it as List means that the result of 'new List.unmodifiable(...)' will
never be optimized since it could be any implementation of List.

At least with JSArray we won't always be calling getInterceptor().

2. Open a bug against Dart2JS to recognize that unmodifiable lists have fixed
length.  Add a TODO here referencing the issue.

https://codereview.chromium.org/1056353004/diff/20001/sdk/lib/internal/list.dart
File sdk/lib/internal/list.dart (right):

https://codereview.chromium.org/1056353004/diff/20001/sdk/lib/internal/list.d...
sdk/lib/internal/list.dart:390: * The unmodifialbe list type is similar to the
one used by const lists.
spelling

[kevmoo, 2015-04-23 00:31:33]

On 2015/04/22 21:17:31, sra1 wrote:
> Optimization of this is poor.
> 
>
https://codereview.chromium.org/1056353004/diff/20001/sdk/lib/_internal/compi...
> File sdk/lib/_internal/compiler/js_lib/js_array.dart (right):
> 
>
https://codereview.chromium.org/1056353004/diff/20001/sdk/lib/_internal/compi...
> sdk/lib/_internal/compiler/js_lib/js_array.dart:86: return JS('List', '#',
> list);
> 1. Change 'List' to 'JSArray'.
> 
> Leaving it as List means that the result of 'new List.unmodifiable(...)' will
> never be optimized since it could be any implementation of List.
> 
> At least with JSArray we won't always be calling getInterceptor().
> 
> 2. Open a bug against Dart2JS to recognize that unmodifiable lists have fixed
> length.  Add a TODO here referencing the issue.
> 
>
https://codereview.chromium.org/1056353004/diff/20001/sdk/lib/internal/list.dart
> File sdk/lib/internal/list.dart (right):
> 
>
https://codereview.chromium.org/1056353004/diff/20001/sdk/lib/internal/list.d...
> sdk/lib/internal/list.dart:390: * The unmodifialbe list type is similar to the
> one used by const lists.
> spelling

DCB: please add a note to CHANGELOG.md

[Lasse Reichstein Nielsen, 2015-04-23 06:02:26]

On 2015/04/23 00:31:33, kevmoo wrote:
> 
> DCB: please add a note to CHANGELOG.md

Re CHANGELOG.md - it seems to be using a format where there revision number is
mentioned on the change.
That makes it hard to add the change note in the same commit as the change since
you don't know the revision number before committing.
(Well, I did manage to put it in before committing, by predicting that the next
revision was one later than the current, but that's incredibly fragile).
What is the recommended way to add chages to the change0-log?

[kevmoo, 2015-04-23 07:01:09]

On 2015/04/23 06:02:26, Lasse Reichstein Nielsen wrote:
> On 2015/04/23 00:31:33, kevmoo wrote:
> > 
> > DCB: please add a note to CHANGELOG.md
> 
> Re CHANGELOG.md - it seems to be using a format where there revision number is
> mentioned on the change.
> That makes it hard to add the change note in the same commit as the change
since
> you don't know the revision number before committing.
> (Well, I did manage to put it in before committing, by predicting that the
next
> revision was one later than the current, but that's incredibly fragile).
> What is the recommended way to add chages to the change0-log?

Guessing 1.11 at this point is totally valid.

Let me get back to you, though.