Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Side by Side Diff: runtime/lib/array_patch.dart

Issue 1056353004: Add List.unmodifiable constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove left-over debug coide. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // The _GrowableArrayMarker class is used to signal to the List() factory 5 // The _GrowableArrayMarker class is used to signal to the List() factory
6 // whether a parameter was passed. 6 // whether a parameter was passed.
7 class _GrowableArrayMarker implements int { 7 class _GrowableArrayMarker implements int {
8 const _GrowableArrayMarker(); 8 const _GrowableArrayMarker();
9 } 9 }
10 10
(...skipping 30 matching lines...) Expand all
41 return list; 41 return list;
42 } 42 }
43 List<E> list = new _GrowableList<E>(0); 43 List<E> list = new _GrowableList<E>(0);
44 for (E e in elements) { 44 for (E e in elements) {
45 list.add(e); 45 list.add(e);
46 } 46 }
47 if (growable) return list; 47 if (growable) return list;
48 return makeListFixedLength(list); 48 return makeListFixedLength(list);
49 } 49 }
50 50
51 /* patch */ factory List.unmodifiable(Iterable elements) {
52 List result = new List<E>.from(elements, growable: false);
53 return makeFixedListUnmodifiable(result);
54 }
55
51 // Factory constructing a mutable List from a parser generated List literal. 56 // Factory constructing a mutable List from a parser generated List literal.
52 // [elements] contains elements that are already type checked. 57 // [elements] contains elements that are already type checked.
53 factory List._fromLiteral(List elements) { 58 factory List._fromLiteral(List elements) {
54 if (elements.isEmpty) { 59 if (elements.isEmpty) {
55 return new _GrowableList<E>(0); 60 return new _GrowableList<E>(0);
56 } 61 }
57 var result = new _GrowableList<E>.withData(elements); 62 var result = new _GrowableList<E>.withData(elements);
58 result._setLength(elements.length); 63 result._setLength(elements.length);
59 return result; 64 return result;
60 } 65 }
61 } 66 }
OLDNEW
« no previous file with comments | « no previous file | runtime/lib/growable_array.cc » ('j') | sdk/lib/_internal/compiler/js_lib/js_array.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698