Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1055243005: Detect an old PhantomJS and emit a nice error. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Detect an old PhantomJS and emit a nice error. Closes #70 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/e32e7d2b38445d33d71e83e31abe4555df5126f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M lib/src/runner/browser/phantom_js.dart View 3 chunks +9 lines, -0 lines 0 comments Download
M lib/src/runner/browser/server.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 8 months ago (2015-04-14 23:06:31 UTC) #1
kevmoo
lgtm
5 years, 8 months ago (2015-04-14 23:33:24 UTC) #2
nweiz
5 years, 8 months ago (2015-04-14 23:53:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e32e7d2b38445d33d71e83e31abe4555df5126f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698