Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: lib/src/runner/browser/server.dart

Issue 1055243005: Detect an old PhantomJS and emit a nice error. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/phantom_js.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/server.dart
diff --git a/lib/src/runner/browser/server.dart b/lib/src/runner/browser/server.dart
index 6c1d52d0e038d8a64c85af0e25ba6ff3f16441a2..963a6b84dccafbedf7d752e1f372a96db2c66ce9 100644
--- a/lib/src/runner/browser/server.dart
+++ b/lib/src/runner/browser/server.dart
@@ -329,7 +329,10 @@ void main() {
if (manager != null) return manager;
var completer = new Completer();
- _browserManagers[platform] = completer.future;
+
+ // Swallow errors, since they're already being surfaced through the return
+ // value and [browser.onError].
+ _browserManagers[platform] = completer.future.catchError((_) {});
var path = _webSocketHandler.create(webSocketHandler((webSocket) {
completer.complete(new BrowserManager(webSocket));
}));
« no previous file with comments | « lib/src/runner/browser/phantom_js.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698