replace request.node with request.target

replace request.node with request.target

BUG=
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44886

[danrubel, 2015-04-03 16:54:14]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-04-03 19:04:29]

lgtm

https://codereview.chromium.org/1054363003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/completion/keyword_computer.dart
(left):

https://codereview.chromium.org/1054363003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/keyword_computer.dart:246:
static bool _isInClassMemberBody(AstNode node) {
Any particular reason for dropping the "static" keyword?

https://codereview.chromium.org/1054363003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/completion/keyword_computer.dart
(right):

https://codereview.chromium.org/1054363003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/keyword_computer.dart:73: if
(entity == node.rightBracket) {
Shouldn't these suggestions also be made if entity is a class member?  That
would cover cases where the user is inserting a new class member somewhere other
than the end of the class, e.g.:

class C {
  oneClassMember();
  ^
  anotherClassMember();
}

[danrubel, 2015-04-03 20:34:29]

Committed patchset #3 (id:40001) manually as 44886 (presubmit successful).

[danrubel, 2015-04-03 20:54:01]

https://codereview.chromium.org/1054363003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/completion/keyword_computer.dart
(right):

https://codereview.chromium.org/1054363003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/keyword_computer.dart:73: if
(entity == node.rightBracket) {
On 2015/04/03 19:04:29, Paul Berry wrote:
> Shouldn't these suggestions also be made if entity is a class member?  That
> would cover cases where the user is inserting a new class member somewhere
other
> than the end of the class, e.g.:
> 
> class C {
>   oneClassMember();
>   ^
>   anotherClassMember();
> }

Good catch! https://codereview.chromium.org/1057403003/