replace request.node with request.target

pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.dart;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/arglist_computer.dart';
@@ skipping 104 matching lines @@
 
   /**
    * Compute suggestions based upon cached information only
    * then send an initial response to the client.
    * Return a list of computers for which [computeFull] should be called
    */
   List<DartCompletionComputer> computeFast(DartCompletionRequest request) {
     return request.performance.logElapseTime('computeFast', () {
       CompilationUnit unit = context.parseCompilationUnit(source);
       request.unit = unit;
-      request.node = new NodeLocator.con1(request.offset).searchWithin(unit);
       request.target = new CompletionTarget.forOffset(unit, request.offset);
       request.replacementOffset = request.offset;
       request.replacementLength = 0;
-      if (request.node == null) {
+      if (request.offset < 0 || request.offset > unit.end) {
         sendResults(request, true);
         return [];
       }
 
       var entity = request.target.entity;
       Token token = entity is AstNode ? entity.beginToken : entity;
       if (token != null &&
           token.offset <= request.offset &&
           (token.type == TokenType.KEYWORD ||
               token.type == TokenType.IDENTIFIER)) {
@@ skipping 26 matching lines @@
       if (controller.isClosed) {
         return;
       }
       request.performance.logElapseTime('waitForAnalysis');
       if (unit == null) {
         sendResults(request, true);
         return;
       }
       request.performance.logElapseTime('computeFull', () {
         request.unit = unit;
-        request.node = new NodeLocator.con1(request.offset).searchWithin(unit);
         // TODO(paulberry): Do we need to invoke _ReplacementOffsetBuilder
         // again?
         request.target = new CompletionTarget.forOffset(unit, request.offset);
         int count = todo.length;
         todo.forEach((DartCompletionComputer c) {
           String name = c.runtimeType.toString();
           String completeTag = 'computeFull $name complete';
           request.performance.logStartTime(completeTag);
           request.performance.logElapseTime('computeFull $name', () {
             c.computeFull(request).then((bool changed) {
@@ skipping 85 matching lines @@
   final DartCompletionCache cache;
 
   /**
    * The compilation unit in which the completion was requested. This unit
    * may or may not be resolved when [DartCompletionComputer.computeFast]
    * is called but is resolved when [DartCompletionComputer.computeFull].
    */
   CompilationUnit unit;
 
   /**
-   * The node in which the completion occurred. This node
-   * may or may not be resolved when [DartCompletionComputer.computeFast]
-   * is called but is resolved when [DartCompletionComputer.computeFull].
-   */
-  AstNode node;
-
-  /**
    * The completion target.  This determines what part of the parse tree
    * will receive the newly inserted text.
-   *
-   * TODO(paulberry) gradually transition code over to using this rather than
-   * [node].
    */
   CompletionTarget target;
 
   /**
    * Information about the types of suggestions that should be included.
    */
   OpType _optype;
 
   /**
    * The offset of the start of the text to be replaced.
@@ skipping 80 matching lines @@
             parameterNames: suggestion.parameterNames,
             parameterTypes: suggestion.parameterTypes,
             requiredParameterCount: suggestion.requiredParameterCount,
             hasNamedParameters: suggestion.hasNamedParameters,
             returnType: suggestion.returnType,
             element: suggestion.element);
       }
     }
   }
 }