Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1053813002: Issue 23068. Constructors should have the same const/factory modifiers to match. (Closed)

Created:
5 years, 8 months ago by scheglov
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Issue 23068. Constructors should have the same const/factory modifiers to match. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=23068 Committed: https://code.google.com/p/dart/source/detail?r=44845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 8 months ago (2015-04-01 20:01:51 UTC) #1
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-01 20:31:51 UTC) #2
scheglov
5 years, 8 months ago (2015-04-01 22:08:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44845 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698