pkg/analyzer/lib/src/generated/incremental_resolver.dart - Issue 1053813002: Issue 23068. Constructors should have the same const/factory modifiers to match.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/incremental_resolver.dart

Issue 1053813002: Issue 23068. Constructors should have the same const/factory modifiers to match. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/lib/src/generated/incremental_resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/incremental_resolver.dart b/pkg/analyzer/lib/src/generated/incremental_resolver.dart

index 02047c400c5983fec69b3ae0a2424d564560085c..de06b8241b47ceaac24322e192eff63d505a7ce5 100644

--- a/pkg/analyzer/lib/src/generated/incremental_resolver.dart

+++ b/pkg/analyzer/lib/src/generated/incremental_resolver.dart

@@ -185,6 +185,8 @@ class DeclarationMatcher extends RecursiveAstVisitor {

? _enclosingClass.unnamedConstructor

: _enclosingClass.getNamedConstructor(constructorName.name);

_processElement(element);

+ _assertEquals(node.constKeyword != null, element.isConst);

+ _assertEquals(node.factoryKeyword != null, element.isFactory);

_assertCompatibleParameters(node.parameters, element.parameters);

// TODO(scheglov) debug null Location

if (element != null) {

« no previous file with comments | « no previous file | pkg/analyzer/test/generated/incremental_resolver_test.dart » ('j') | no next file with comments »