Simplifies standalone VM Android build.

Simplifies standalone VM Android build.

This change also avoids the need to
do another 'gclient runhooks' when switching
between Android and Linux builds, and between
IA32 and ARM Android builds.

gyp does not allow 'libraries' sections inside of
configurations. Therefore, since some architecture
specific paths, libraries, etc. must be specified
on the Android NDK's linker command line, to avoid
re-gyping when switching between Android IA32 and ARM,
this change moves the architecture specific linker
flags to a script, android_link.py.

To avoid re-gyping when swtiching between Linux and
Android, this change creates new configurations
that specify the target OS as well as the the target
architecture, e.g. ReleaseLinuxARM or ReleaseAndroidARM
instead of ReleaseARM.

This change also adds a --toolchain flag to build.py,
and removes obsoleted logic for setting up the Android
build.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31340

[zra, 2013-12-16 20:37:07]

ping

[zra, 2013-12-19 16:39:07]

ping

[Ivan Posva, 2013-12-20 06:53:47]

LGTM with clargincomments added.

-Ivan

https://codereview.chromium.org/105223002/diff/210001/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/105223002/diff/210001/tools/build.py#newcode53
tools/build.py:53: result.add_option("-t", "--toolchain",
Does this allow us to set an arbitrary toolchain going forward? Whether we are
cross-building or not?

https://codereview.chromium.org/105223002/diff/210001/tools/build.py#newcode108
tools/build.py:108: if not arch in ['ia32', 'arm']:
How are you supposed to cross-build for MIPS? It seems to me as if this prevents
it, but I am pretty certain that you plan to support MIPS cross-compilation.

https://codereview.chromium.org/105223002/diff/210001/tools/gyp/configuration...
File tools/gyp/configurations.gypi (right):

https://codereview.chromium.org/105223002/diff/210001/tools/gyp/configuration...
tools/gyp/configurations.gypi:26: [ 'OS=="android"', { 'chrome_target_os':
'Android',},
Why are you setting chrome_target_os here, while all the others are setting
dart_target_os? Also why is the chrome_target_os property overridden immediately
on the line below. At least some comment explaining the reasoning would be
helpful.

[zra, 2013-12-20 16:09:47]

Thanks!

https://codereview.chromium.org/105223002/diff/210001/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/105223002/diff/210001/tools/build.py#newcode53
tools/build.py:53: result.add_option("-t", "--toolchain",
On 2013/12/20 06:53:47, Ivan Posva wrote:
> Does this allow us to set an arbitrary toolchain going forward? Whether we are
> cross-building or not?

Yes. SetTools is run whether we are cross-building or not. It currently expects
e.g. the C compiler to have suffix '-gcc', the C++ compiler to have suffix
'-g++', etc. since that is how our current cross toolchains are set up, but we
could relax that later if need be.

https://codereview.chromium.org/105223002/diff/210001/tools/build.py#newcode108
tools/build.py:108: if not arch in ['ia32', 'arm']:
On 2013/12/20 06:53:47, Ivan Posva wrote:
> How are you supposed to cross-build for MIPS? It seems to me as if this
prevents
> it, but I am pretty certain that you plan to support MIPS cross-compilation.

This prevents Android MIPS since it isn't supported yet. See "if os !=
'android'" above. Linux MIPS will still go through.

https://codereview.chromium.org/105223002/diff/210001/tools/gyp/configuration...
File tools/gyp/configurations.gypi (right):

https://codereview.chromium.org/105223002/diff/210001/tools/gyp/configuration...
tools/gyp/configurations.gypi:26: [ 'OS=="android"', { 'chrome_target_os':
'Android',},
On 2013/12/20 06:53:47, Ivan Posva wrote:
> Why are you setting chrome_target_os here, while all the others are setting
> dart_target_os? Also why is the chrome_target_os property overridden
immediately
> on the line below. At least some comment explaining the reasoning would be
> helpful.

Added clarifying comment. The 'line below' is the else branch of the
'OS=="android"' condition.

[zra, 2013-12-20 17:51:45]

Committed patchset #13 manually as r31340 (presubmit successful).