Issue 105213002: MirrorsUsed values are interpreted differently based on position, so they must be cached in differe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105213002: MirrorsUsed values are interpreted differently based on position, so they must be cached in differe… (Closed)

Created:
7 years ago by ahe

Modified:
7 years ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MirrorsUsed values are interpreted differently based on position, so they must be cached in different caches. This is the correct fix for what r30615 and r30626 worked around. Revert "Fix host-checked mode error." This reverts r30615. Revert "Most host-checked fixes." This reverts r30626. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=30890

Patch Set 1 : #

Patch Set 2 : Tweak comment #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -15 lines)			Patch
	M	dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart	View		5 chunks	+16 lines, -14 lines	0 comments	Download
	M	dart/tests/compiler/dart2js/mirrors_used_test.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r30890 (presubmit successful).

Expand Messages | Collapse Messages