Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2524)

Unified Diff: dart/tests/compiler/dart2js/mirrors_used_test.dart

Issue 105213002: MirrorsUsed values are interpreted differently based on position, so they must be cached in differe… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Tweak comment Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/compiler/dart2js/mirrors_used_test.dart
diff --git a/dart/tests/compiler/dart2js/mirrors_used_test.dart b/dart/tests/compiler/dart2js/mirrors_used_test.dart
index aa25c0da8c892d192038f5757a98be9611623185..1eb58921080df0bd55a5edd5dfaeb13f66121bdc 100644
--- a/dart/tests/compiler/dart2js/mirrors_used_test.dart
+++ b/dart/tests/compiler/dart2js/mirrors_used_test.dart
@@ -123,7 +123,9 @@ void main() {
const MEMORY_SOURCE_FILES = const <String, String> {
'main.dart': """
-@MirrorsUsed(targets: const [Foo], override: '*')
+// The repeated constant value for symbols and targets used to crash dart2js in
+// host-checked mode, and could potentially lead to other problems.
+@MirrorsUsed(symbols: 'Foo', targets: 'Foo', override: '*')
import 'dart:mirrors';
import 'library.dart';
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698