Issue 1051273007: ReApply: Issue 23133. Fix for restoring 'package:' uris on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1051273007: ReApply: Issue 23133. Fix for restoring 'package:' uris on Windows. (Closed)

Created:
5 years, 8 months ago by scheglov

Modified:
5 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

ReApply: Issue 23133. Fix for restoring 'package:' uris on Windows. There was a bug in the previous version https://codereview.chromium.org//1070203002 We used system path context instead of the one from the given ResourceProvider. So, it worked, but was failing tests on Windows, because we always use posix style. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=23133 Committed: https://code.google.com/p/dart/source/detail?r=45069

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	pkg/analyzer/lib/source/package_map_resolver.dart	View		2 chunks	+6 lines, -3 lines	0 comments	Download
	M	pkg/analyzer/test/source/package_map_resolver_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 8 months ago (2015-04-10 15:27:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45069 (presubmit successful).